linux-kernel - Re: [PATCH v8 2/3] mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK1f24keXQbx8jh=Jd27mRk4Km-viyMLcQh=VqReG7LLzYCCXQ@mail.gmail.com>
Date: Fri, 14 Jun 2024 15:46:34 +0800
From: Lance Yang <ioworker0@...il.com>
To: David Hildenbrand <david@...hat.com>
Cc: akpm@...ux-foundation.org, willy@...radead.org, sj@...nel.org, 
	baolin.wang@...ux.alibaba.com, maskray@...gle.com, ziy@...dia.com, 
	ryan.roberts@....com, 21cnbao@...il.com, mhocko@...e.com, 
	fengwei.yin@...el.com, zokeefe@...gle.com, shy828301@...il.com, 
	xiehuan09@...il.com, libang.li@...group.com, wangkefeng.wang@...wei.com, 
	songmuchun@...edance.com, peterx@...hat.com, minchan@...nel.org, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 2/3] mm/rmap: integrate PMD-mapped folio splitting into
 pagewalk loop

On Fri, Jun 14, 2024 at 3:34 PM David Hildenbrand <david@...hat.com> wrote:
>
> On 14.06.24 03:51, Lance Yang wrote:
> > In preparation for supporting try_to_unmap_one() to unmap PMD-mapped
> > folios, start the pagewalk first, then call split_huge_pmd_address() to
> > split the folio.
> >
> > Suggested-by: David Hildenbrand <david@...hat.com>
> > Suggested-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> > Signed-off-by: Lance Yang <ioworker0@...il.com>
> > ---
>
> Would have converted that VM_BUG_ON to a VM_WARN_ON_ONCE, but it's just
> moving code, so no big deal.

OK, let’s leave it as is for now ;)

>
> Thanks!
>
> Acked-by: David Hildenbrand <david@...hat.com>

Thanks for taking time to review!
Lance

>
> --
> Cheers,
>
> David / dhildenb
>