linux-kernel - Re: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5514: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59487896-1ce0-4422-bafb-a0f6f9ef065c@kernel.org>
Date: Fri, 14 Jun 2024 10:31:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5514: Convert to
 dtschema

On 14/06/2024 05:38, Animesh Agarwal wrote:
> +maintainers:
> +  - Animesh Agarwal <animeshagarwal28@...il.com>

Missing ref to spi peri props.

> +
> +properties:
> +  compatible:
> +    const: realtek,rt5514
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: Master clock to the CODEC
> +
> +  clock-names:
> +    items:
> +      - const: mclk
> +
> +  interrupts:
> +    maxItems: 1
> +    description: The interrupt number to the cpu.
> +
> +  realtek,dmic-init-delay-ms:
> +    description: Set the DMIC initial delay (ms) to wait it ready for I2C.

wakeup-source and maybe other properties. I don't think you tested DTS.


unevaluatedProperties: false.



Best regards,
Krzysztof