linux-kernel - Re: [PATCH 2/2] ASoC: dt-bindings: realtek,rt5631: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 10:34:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Animesh Agarwal <animeshagarwal28@....com>
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: realtek,rt5631: Convert to
 dtschema

On 14/06/2024 05:38, Animesh Agarwal wrote:
> Convert the ALC5631/RT5631 audio CODEC bindings to DT Schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@....com>
> Cc: Daniel Baluta <daniel.baluta@....com>
> ---
>  .../bindings/sound/realtek,rt5631.yaml        | 63 +++++++++++++++++++
>  .../devicetree/bindings/sound/rt5631.txt      | 48 --------------
>  2 files changed, 63 insertions(+), 48 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/rt5631.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
> new file mode 100644
> index 000000000000..05b83d907b38
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/realtek,rt5631.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ALC5631/RT5631 audio CODEC
> +
> +description: |

Please keep the order as in example-schema, so first maintainers then
description. This applies to all your patches.

> +  This device supports I2C only.
> +
> +  Pins on the device (for linking into audio routes):
> +      * SPK_OUT_R_P
> +      * SPK_OUT_R_N
> +      * SPK_OUT_L_P
> +      * SPK_OUT_L_N
> +      * HP_OUT_L
> +      * HP_OUT_R
> +      * AUX_OUT2_LP
> +      * AUX_OUT2_RN
> +      * AUX_OUT1_LP
> +      * AUX_OUT1_RN
> +      * AUX_IN_L_JD
> +      * AUX_IN_R_JD
> +      * MONO_IN_P
> +      * MONO_IN_N
> +      * MIC1_P
> +      * MIC1_N
> +      * MIC2_P
> +      * MIC2_N
> +      * MONO_OUT_P
> +      * MONO_OUT_N
> +      * MICBIAS1
> +      * MICBIAS2
> +
> +maintainers:
> +  - Animesh Agarwal <animeshagarwal28@...il.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - realtek,alc5631
> +      - realtek,rt5631
> +
> +  reg:
> +    maxItems: 1

Just open the DTS and immediately you will see it is incomplete.

Best regards,
Krzysztof