linux-kernel - Re: [PATCH v6 5/8] arm64: dts: ti: k3-j722s: Move MAIN domain overrides to k3-j722s-main.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 12:53:37 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Siddharth Vadapalli <s-vadapalli@...com>, nm@...com, vigneshr@...com,
 afd@...com, kristo@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, u-kumar1@...com, danishanwar@...com,
 srk@...com
Subject: Re: [PATCH v6 5/8] arm64: dts: ti: k3-j722s: Move MAIN domain
 overrides to k3-j722s-main.dtsi

Hi Siddharth,

On 12/06/2024 16:24, Siddharth Vadapalli wrote:
> Since the MAIN domain peripherals specific to J722S SoC are present in the
> "k3-j722s-main.dtsi" file, move the overrides for the MAIN domain from the
> "k3-j722s.dtsi" file to the "k3-j722s-main.dtsi" file.

Overrides is kind of a misnomer here. It looks like these are J722S specific
changes.

> 
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
> ---
> This patch has been newly introduced in this series and doesn't have a
> Changelog.
> 
>  arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 11 +++++++++++
>  arch/arm64/boot/dts/ti/k3-j722s.dtsi      | 11 -----------
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> index 84378fc839d6..b75dab8230c2 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> @@ -38,3 +38,14 @@ usb1: usb@...00000{
>  		};
>  	};
>  };
> +
> +/* MAIN domain overrides */
> +
> +&inta_main_dmss {
> +	ti,interrupt-ranges = <7 71 21>;
> +};
> +
> +&oc_sram {
> +	reg = <0x00 0x70000000 0x00 0x40000>;
> +	ranges = <0x00 0x00 0x70000000 0x40000>;
> +};
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s.dtsi b/arch/arm64/boot/dts/ti/k3-j722s.dtsi
> index 1bcbc9152ff0..14c6c6a332ef 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j722s.dtsi
> @@ -232,14 +232,3 @@ cbass_wakeup: bus@...000 {
>  
>  /* Include J722S specific peripherals */
>  #include "k3-j722s-main.dtsi"
> -
> -/* Main domain overrides */
> -
> -&inta_main_dmss {
> -	ti,interrupt-ranges = <7 71 21>;
> -};
> -
> -&oc_sram {
> -	reg = <0x00 0x70000000 0x00 0x40000>;
> -	ranges = <0x00 0x00 0x70000000 0x40000>;
> -};
These are originally set in k3-am62p-j722s-common-main.dtsi
which cannot be as they are not common to both SoCs.

Should we be moving the AM62 specific portion into k3-am62p-main.dtsi.

So they are no longer overrides but SoC specific changes?

-- 
cheers,
-roger