linux-kernel - Re: [PATCH v2 2/5] regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240614110156.230f5109@donnerap.manchester.arm.com>
Date: Fri, 14 Jun 2024 11:01:56 +0100
From: Andre Przywara <andre.przywara@....com>
To: Lee Jones <lee@...nel.org>, Philippe Simons <simons.philippe@...il.com>
Cc: Chen-Yu Tsai <wens@...e.org>, Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev, Jernej Skrabec
 <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, Ryan
 Walklin <ryan@...ttoast.com>, Chris Morgan <macroalpha82@...il.com>
Subject: Re: [PATCH v2 2/5] regulator: axp20x: AXP717: fix LDO supply rails
 and off-by-ones

On Fri, 14 Jun 2024 09:12:24 +0100
Lee Jones <lee@...nel.org> wrote:

Hi Lee,

> On Wed, 12 Jun 2024, Andre Przywara wrote:
> 
> > Hi Broonie,
> > 
> > On 18/04/2024 01:07, Andre Przywara wrote:  
> > > The X-Powers AXP717 PMIC has separate input supply pins for each group
> > > of LDOs, so they are not all using the same DCDC1 input, as described
> > > currently.
> > > 
> > > Replace the "supply" member of each LDO description with the respective
> > > group supply name, so that the supply dependencies can be correctly
> > > described in the devicetree.
> > > 
> > > Also fix two off-by-ones in the regulator macros, after some double
> > > checking the numbers against the datasheet. This uncovered a bug in the
> > > datasheet: add a comment to document this.
> > > 
> > > Fixes: d2ac3df75c3a ("regulator: axp20x: add support for the AXP717")
> > > Signed-off-by: Andre Przywara <andre.przywara@....com>  
> > 
> > Can you please take (at least) this one patch as a fix for 6.10? Applies
> > cleanly on top of v6.10-rc3. The changes are not super-critical, but worth
> > fixing nevertheless.  
> 
> FWIW, I have no idea what's going on with this set now.
> 
> Once all of the necessary patches have been expedited, please gather
> together what's left and I'll take them via MFD.

Yes, we dropped the ball on this one a bit, apologies.
Broonie just took 2/5, so I will resend 3/5-5/5 as a new series, targeting
6.11.

Cheers,
Andre.