linux-kernel - Re: [PATCH v9 1/1] gpio: add sloppy logic analyzer using polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <slpwvai5q24qwymh7nktihvykmlhi5j3nhqjxruxb6yacruu47@27b7rhykw2f3>
Date: Fri, 14 Jun 2024 12:03:00 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, 
	Linus Walleij <linus.walleij@...aro.org>, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, 
	Jonathan Corbet <corbet@....net>, Kent Gibson <warthog618@...il.com>, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v9 1/1] gpio: add sloppy logic analyzer using polling

Hi Arnd, everyone,

> I could imagine treating both gpio-virtuser and this code as
> a gpiolib extension rather than a consumer (which is usually
> part of some other subsystem's driver).

I have difficulties seeing this. For the analyzer, at least. It does not
extend gpiolib in a way another consumer could make use of it?

> It would also make sense to me to separate gpio providers
> from gpiolib in a way, moving one or both of them into a
> subdirectory of drivers/gpio/.

I'd also like 'drivers/gpio/providers' and leave the core stuff (incl.
the analyzer) in 'drivers/gpio'. But I am biased, I2C looks like this :)
And yes, this is some churn and git-history spoiling.

> gpiolib-virtuser.c and gpiolib-sloppy-logic-analyzer.c

'gpio-tool-sloppy-logic-analyzer.c' ? Based on what gets added to
Kconfig with this patch:

	+menu "GPIO hardware hacking tools"

Happy hacking,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)