linux-kernel - Re: selftests: ftrace: WARNING: at arch/arm64/kernel/stacktrace.c:112 arch_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANk7y0hEQVTRTZWCJiC8d8pmQVy7fvdL_qQM_Sa__YuBa-5s=A@mail.gmail.com>
Date: Fri, 14 Jun 2024 14:14:50 +0200
From: Puranjay Mohan <puranjay12@...il.com>
To: Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: open list <linux-kernel@...r.kernel.org>, 
	Linux ARM <linux-arm-kernel@...ts.infradead.org>, lkft-triage@...ts.linaro.org, 
	Linux Regressions <regressions@...ts.linux.dev>, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, Catalin Marinas <catalin.marinas@....com>, 
	Nianyao Tang <tangnianyao@...wei.com>, Mark Rutland <mark.rutland@....com>, 
	Stephen Boyd <swboyd@...omium.org>, Puranjay Mohan <puranjay@...nel.org>, 
	James Morse <james.morse@....com>, Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
	Dan Carpenter <dan.carpenter@...aro.org>, Anders Roxell <anders.roxell@...aro.org>, 
	Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: selftests: ftrace: WARNING: at arch/arm64/kernel/stacktrace.c:112 arch_stack_walk

Hi Naresh,

Thanks for finding this.

On Thu, Jun 13, 2024 at 3:16 PM Naresh Kamboju
<naresh.kamboju@...aro.org> wrote:
>
> The following kernel warning noticed on arm64 qemu-arm64 and rk3399-rock-pi-4
> device while running selftests ftrace tests on Linux next-20240613.
>
> This is always reproducible on qemu-arm64 and rock-pi-4 device with
> kselftest merge configs
>
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
>
> Test log:
> -------
> kselftest: Running tests in ftrace
> TAP version 13
> 1..1
> # timeout set to 0
> # selftests: ftrace: ftracetest-ktap
> # unlink: cannot unlink
> '/opt/kselftests/default-in-kernel/ftrace/logs/latest': No such file
> or directory
> # TAP version 13
> # 1..141
> # ok 1 Basic trace file check
> <4>[   96.183553] ------------[ cut here ]------------
> <4>[ 96.187100] WARNING: CPU: 1 PID: 538 at
> arch/arm64/kernel/stacktrace.c:112 arch_stack_walk


29c1c24a2707 ("function_graph: Fix up ftrace_graph_ret_addr()") made
the ftrace_graph_ret_addr() use the
'idx' pointer to optimise the stack unwinding but arm64, riscv, and
some other architectures pass `NULL` for this
parameter. The fix for this is to pass a valid pointer to
ftrace_graph_ret_addr() like x86_64 is doing.

I will send a patch to fix this unless someone else has already sent one.

Thanks,
Puranjay