[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1ea35568-bfe5-430e-9f4b-edef17f0b22b@redhat.com>
Date: Fri, 14 Jun 2024 14:28:08 +0200
From: David Hildenbrand <david@...hat.com>
To: John Hubbard <jhubbard@...dia.com>,
Andrew Morton <akpm@...ux-foundation.org>, Jeff Xu <jeffxu@...omium.org>,
Shuah Khan <shuah@...nel.org>
Cc: Andrei Vagin <avagin@...gle.com>,
Axel Rasmussen <axelrasmussen@...gle.com>,
Christian Brauner <brauner@...nel.org>, Kees Cook <kees@...nel.org>,
Kent Overstreet <kent.overstreet@...ux.dev>,
"Liam R . Howlett" <Liam.Howlett@...cle.com>,
Muhammad Usama Anjum <usama.anjum@...labora.com>,
Peter Xu <peterx@...hat.com>, Rich Felker <dalias@...c.org>,
linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing
__NR_mseal
On 14.06.24 04:30, John Hubbard wrote:
> The selftests/mm build isn't exactly "broken", according to the current
> documentation, which still claims that one must run "make headers",
> before building the kselftests. However, according to the new plan to
> get rid of that requirement [1], they are future-broken: attempting to
> build selftests/mm *without* first running "make headers" will fail due
> to not finding __NR_mseal.
>
> Therefore, add ./usr/include/asm/unistd_[32|x32|64].h (created via
> "make headers") to tools/uapi/, and change the selftests/mm files that
> require __NR_mseal to include from the correct location. The way to do
> so is to include <linux/unistd.h> instead of just <unistd.h>.
>
> [1] commit e076eaca5906 ("selftests: break the dependency upon local
> header files")
>
> Fixes: 4926c7a52de7 ("selftest mm/mseal memory sealing")
> Cc: Jeff Xu <jeffxu@...omium.org>
> Cc: David Hildenbrand <david@...hat.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
If it works, great
Acked-by: David Hildenbrand <david@...hat.com>
--
Cheers,
David / dhildenb
Powered by blists - more mailing lists