linux-kernel - Re: [PATCH v2 4/6] selftests/mm: fix vm_util.c build failures: add snapshot of fs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b125057f-5e84-4ba7-adfd-792382cbf0f3@redhat.com>
Date: Fri, 14 Jun 2024 14:29:39 +0200
From: David Hildenbrand <david@...hat.com>
To: John Hubbard <jhubbard@...dia.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Jeff Xu <jeffxu@...omium.org>,
 Shuah Khan <shuah@...nel.org>
Cc: Andrei Vagin <avagin@...gle.com>,
 Axel Rasmussen <axelrasmussen@...gle.com>,
 Christian Brauner <brauner@...nel.org>, Kees Cook <kees@...nel.org>,
 Kent Overstreet <kent.overstreet@...ux.dev>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Peter Xu <peterx@...hat.com>, Rich Felker <dalias@...c.org>,
 linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/6] selftests/mm: fix vm_util.c build failures: add
 snapshot of fs.h

On 14.06.24 04:30, John Hubbard wrote:
> On Ubuntu 23.04, on a clean git tree, the selftests/mm build fails due
> 10 or 20 missing items, all of which are found in fs.h, which is created
> via "make headers". However, as per [1], the idea is to stop requiring
> "make headers", and instead, take a snapshot of the files and check them
> in.
> 
> Here are a few of the build errors:
> 
> vm_util.c:34:21: error: variable has incomplete type 'struct pm_scan_arg'
>          struct pm_scan_arg arg;
> ...
> vm_util.c:45:28: error: use of undeclared identifier 'PAGE_IS_WPALLOWED'
> ...
> vm_util.c:55:21: error: variable has incomplete type 'struct page_region'
> ...
> vm_util.c:105:20: error: use of undeclared identifier 'PAGE_IS_SOFT_DIRTY'
> 
> To fix this, add fs.h, taken from a snapshot of ./usr/include/linux/fs.h
> after running "make headers".
> 
> [1] commit e076eaca5906 ("selftests: break the dependency upon local
> header files")
> 
> Cc: David Hildenbrand <david@...hat.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb