linux-kernel - Re: [PATCH] hippi: fix possible buffer overflow caused by bad DMA value in rr_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b99efc20adda0b1f24ec477b3612caedb704374.camel@redhat.com>
Date: Fri, 14 Jun 2024 15:08:41 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Huai-Yuan Liu <qq810974084@...il.com>, jes@...ined-monkey.org, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org
Cc: linux-hippi@...site.dk, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, baijiaju1990@...il.com
Subject: Re: [PATCH] hippi: fix possible buffer overflow caused by bad DMA
 value in rr_start_xmit()

On Wed, 2024-06-12 at 17:31 +0800, Huai-Yuan Liu wrote:
> The value rrpriv->info->tx_ctrl is stored in DMA memory, and it is
> assigned to txctrl, so txctrl->pi can be modified at any time by malicious
> hardware. Becausetxctrl->pi is assigned to index, buffer overflow may
> occur when the code "rrpriv->tx_skbuff[index]" is executed.
> 
> To address this issue, the index should be checked.
> 
> Fixes: f33a7251c825 ("hippi: switch from 'pci_' to 'dma_' API")
> Signed-off-by: Huai-Yuan Liu <qq810974084@...il.com>
> ---
>  drivers/net/hippi/rrunner.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
> index aa8f828a0ae7..184f0933bca0 100644
> --- a/drivers/net/hippi/rrunner.c
> +++ b/drivers/net/hippi/rrunner.c
> @@ -1440,6 +1440,11 @@ static netdev_tx_t rr_start_xmit(struct sk_buff *skb,
>  	txctrl = &rrpriv->info->tx_ctrl;
>  
>  	index = txctrl->pi;
> +	if (index < 0 || index >= TX_RING_ENTRIES) {

'index' is u32, the first condition is not needed.

> +		printk("invalid index value %02x\n", index);

please use netdev_err() instead.

Thanks,

Paolo