linux-kernel - Re: [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <171837082626.626508.10284320881127428760.robh@kernel.org>
Date: Fri, 14 Jun 2024 07:13:46 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Charles Wang <charles.goodix@...il.com>
Cc: dan.carpenter@...aro.org, jikos@...nel.org, 
 linux-kernel@...r.kernel.org, krzk+dt@...nel.org, 
 devicetree@...r.kernel.org, linux-input@...r.kernel.org, bentiss@...nel.org, 
 hbarnor@...omium.org, dianders@...omium.org, dmitry.torokhov@...il.com
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen


On Fri, 14 Jun 2024 20:15:38 +0800, Charles Wang wrote:
> The Goodix GT7986U touch controller report touch data according to the
> HID protocol through the SPI bus. However, it is incompatible with
> Microsoft's HID-over-SPI protocol.
> 
> Signed-off-by: Charles Wang <charles.goodix@...il.com>
> ---
>  .../bindings/input/goodix,gt7986u.yaml        | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/goodix,gt7986u.example.dtb: touchscreen@0: 'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240614121538.236727-3-charles.goodix@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.