[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bfb1a32d-be14-47e2-9cb0-4d1c75e207f6@moroto.mountain>
Date: Fri, 14 Jun 2024 16:19:14 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev, Yasin Lee <yasin.lee.x@...look.com>,
jic23@...nel.org
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev, andy.shevchenko@...il.com,
lars@...afoo.de, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org, nuno.a@...log.com,
swboyd@...omium.org, u.kleine-koenig@...gutronix.de,
yasin.lee.x@...il.com, yasin.lee.x@...look.com
Subject: Re: [PATCH v4 2/2] iio:proximity:hx9023s: Add TYHX HX9023S sensor
driver
Hi Yasin,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yasin-Lee/iio-proximity-hx9023s-Add-TYHX-HX9023S-sensor-driver/20240607-194446
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/SN7PR12MB81017291E79E6B61A8DEC9A5A4FB2%40SN7PR12MB8101.namprd12.prod.outlook.com
patch subject: [PATCH v4 2/2] iio:proximity:hx9023s: Add TYHX HX9023S sensor driver
config: um-randconfig-r071-20240614 (https://download.01.org/0day-ci/archive/20240614/202406142001.swm6CU40-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202406142001.swm6CU40-lkp@intel.com/
New smatch warnings:
drivers/iio/proximity/hx9023s.c:666 hx9023s_property_get() error: uninitialized symbol 'i'.
drivers/iio/proximity/hx9023s.c:976 hx9023s_trigger_handler() error: uninitialized symbol 'i'.
drivers/iio/proximity/hx9023s.c:996 hx9023s_buffer_preenable() error: uninitialized symbol 'channels'.
Old smatch warnings:
drivers/iio/proximity/hx9023s.c:667 hx9023s_property_get() error: uninitialized symbol 'i'.
vim +/i +666 drivers/iio/proximity/hx9023s.c
6133aa711518da Yasin Lee 2024-06-07 650 static int hx9023s_property_get(struct hx9023s_data *data)
6133aa711518da Yasin Lee 2024-06-07 651 {
6133aa711518da Yasin Lee 2024-06-07 652 int ret, i;
Needs to be initialized. int i = 0;
6133aa711518da Yasin Lee 2024-06-07 653 u32 temp;
6133aa711518da Yasin Lee 2024-06-07 654 struct fwnode_handle *child;
6133aa711518da Yasin Lee 2024-06-07 655 struct device *dev = regmap_get_device(data->regmap);
6133aa711518da Yasin Lee 2024-06-07 656
6133aa711518da Yasin Lee 2024-06-07 657 ret = device_property_read_u32(dev, "channel-in-use", &temp);
6133aa711518da Yasin Lee 2024-06-07 658 if (ret)
6133aa711518da Yasin Lee 2024-06-07 659 return dev_err_probe(dev, ret, "Failed to read channel-in-use property\n");
6133aa711518da Yasin Lee 2024-06-07 660 data->chan_in_use = temp;
6133aa711518da Yasin Lee 2024-06-07 661
6133aa711518da Yasin Lee 2024-06-07 662 device_for_each_child_node(dev, child) {
6133aa711518da Yasin Lee 2024-06-07 663 ret = fwnode_property_read_u32(child, "channel-positive", &temp);
6133aa711518da Yasin Lee 2024-06-07 664 if (ret)
6133aa711518da Yasin Lee 2024-06-07 665 return dev_err_probe(dev, ret,
6133aa711518da Yasin Lee 2024-06-07 @666 "Failed to read channel-positive for channel %d\n", i);
6133aa711518da Yasin Lee 2024-06-07 667 data->ch_data[i].channel_positive = temp;
6133aa711518da Yasin Lee 2024-06-07 668
6133aa711518da Yasin Lee 2024-06-07 669 ret = fwnode_property_read_u32(child, "channel-negative", &temp);
6133aa711518da Yasin Lee 2024-06-07 670 if (ret)
6133aa711518da Yasin Lee 2024-06-07 671 return dev_err_probe(dev, ret,
6133aa711518da Yasin Lee 2024-06-07 672 "Failed to read channel-negative for channel %d\n", i);
6133aa711518da Yasin Lee 2024-06-07 673 data->ch_data[i].channel_negative = temp;
6133aa711518da Yasin Lee 2024-06-07 674
6133aa711518da Yasin Lee 2024-06-07 675 i++;
6133aa711518da Yasin Lee 2024-06-07 676 }
6133aa711518da Yasin Lee 2024-06-07 677
6133aa711518da Yasin Lee 2024-06-07 678 return 0;
6133aa711518da Yasin Lee 2024-06-07 679 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists