linux-kernel - Re: [PATCH v3 0/4] KVM: arm64: pKVM host proxy FF-A fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 14:51:44 +0100
From: Marc Zyngier <maz@...nel.org>
To: Sebastian Ene <sebastianene@...gle.com>
Cc: catalin.marinas@....com,
	james.morse@....com,
	jean-philippe@...aro.org,
	oliver.upton@...ux.dev,
	qperret@...gle.com,
	qwandor@...gle.com,
	sudeep.holla@....com,
	suzuki.poulose@....com,
	tabba@...gle.com,
	will@...nel.org,
	yuzenghui@...wei.com,
	lpieralisi@...nel.org,
	kvmarm@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	kernel-team@...roid.com
Subject: Re: [PATCH v3 0/4] KVM: arm64: pKVM host proxy FF-A fixes

On Thu, 13 Jun 2024 14:20:31 +0100,
Sebastian Ene <sebastianene@...gle.com> wrote:
> 
> Hello,
> 
> 
> This series contains some small fixes for the host pKVM proxy code. I included
> some of the patches that I already sent on the list as part of this series
> to make it easier to keep track of them.
> 
> I verified the functionality with OPTEE as a TEE-OS.
> 
> Changelog:
> 
> v2 -> v3:
> 
> * small fixes on the commit messages
> * applied the Review-by tags from Sudeep. Thank you Sudeep !
>  
> v1 -> v2:
> 
> * applied the feedback received from Will on the FFA_VERSION patch:
>   The spec requires that no other calls to be issued prior to the FFA
>   version negotiation and the current change reflects this. After the
>   version negotiation phase is complete with Trustzone we will just
>   return the hypervisor version.
> 
> * corrected some mistakes on the FFA_PARTITION_INFO_GET patch:
>   - don't trim the number of bytes copied from the hypervisor buffer
>   - introduce FFA_1_0_PARTITON_INFO_SZ definition
>   - simplify the logic when the input flag is specified 
> 
> * collected the Ack from Will and embbeded it in the commit - Thanks Will ! 
> 
> 
> v2:
> https://lore.kernel.org/all/20240515172258.1680881-1-sebastianene@google.com/
> 
> v1:
> 
> * previously posted FFA_PARTITION_INFO_GET patch here:
> https://lore.kernel.org/kvmarm/20240411133249.2134696-1-sebastianene@google.com/
>  -> minor changes from the previous version, look for the current
>     ffa_version in the host_buffer structure
> 
> * previously posted "Fix the identification range for the FF-A smcs" here:
> https://lore.kernel.org/kvmarm/20240322124303.309423-1-sebastianene@google.com/
> 
> Thank you,
> Sebastian
> 
> Sebastian Ene (4):
>   KVM: arm64: Trap FFA_VERSION host call in pKVM
>   KVM: arm64: Add support for FFA_PARTITION_INFO_GET
>   KVM: arm64: Update the identification range for the FF-A smcs
>   KVM: arm64: Use FF-A 1.1 with pKVM
> 
>  arch/arm64/kvm/hyp/include/nvhe/ffa.h |   2 +-
>  arch/arm64/kvm/hyp/nvhe/ffa.c         | 180 +++++++++++++++++++++-----
>  include/linux/arm_ffa.h               |   3 +
>  3 files changed, 152 insertions(+), 33 deletions(-)

Although these are labelled as fixes, I don't think they warrant being
taken into 6.10. So assuming Oliver will take them into 6.11:

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.