linux-kernel - Re: [PATCH] idle: Remove stale RCU comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c223157-3e82-4cf8-aec7-4a7dd6e32d76@intel.com>
Date: Fri, 14 Jun 2024 15:59:14 +0200
From: "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>
To: Christian Loehle <christian.loehle@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner
	<tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar
	<mingo@...hat.com>, Steven Rostedt <rostedt@...dmis.org>, Vincent Guittot
	<vincent.guittot@...aro.org>
Subject: Re: [PATCH] idle: Remove stale RCU comment

On 6/3/2024 5:30 PM, Christian Loehle wrote:
> The call of rcu_idle_enter() from within cpuidle_idle_call() was
> removed in commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper
> into the idle path") which makes the comment out of place.
>
> Signed-off-by: Christian Loehle <christian.loehle@....com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>


> ---
>   kernel/sched/idle.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
> index 6135fbe83d68..3cc1a592d9a1 100644
> --- a/kernel/sched/idle.c
> +++ b/kernel/sched/idle.c
> @@ -179,12 +179,6 @@ static void cpuidle_idle_call(void)
>   		return;
>   	}
>   
> -	/*
> -	 * The RCU framework needs to be told that we are entering an idle
> -	 * section, so no more rcu read side critical sections and one more
> -	 * step to the grace period
> -	 */
> -
>   	if (cpuidle_not_available(drv, dev)) {
>   		tick_nohz_idle_stop_tick();
>