linux-kernel - Re: [PATCH] kasan: fix bad call to unpoison_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+fCnZfRtGNYw953NMm9s3JTsv6gNQJSbREcnbcUe6Zsgeh_6Q@mail.gmail.com>
Date: Fri, 14 Jun 2024 16:33:25 +0200
From: Andrey Konovalov <andreyknvl@...il.com>
To: Marco Elver <elver@...gle.com>
Cc: andrey.konovalov@...ux.dev, Andrew Morton <akpm@...ux-foundation.org>, 
	Alexander Potapenko <glider@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, 
	Andrey Ryabinin <ryabinin.a.a@...il.com>, kasan-dev@...glegroups.com, linux-mm@...ck.org, 
	Brad Spengler <spender@...ecurity.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kasan: fix bad call to unpoison_slab_object

On Fri, Jun 14, 2024 at 4:29 PM Marco Elver <elver@...gle.com> wrote:
>
> On Fri, 14 Jun 2024 at 16:16, <andrey.konovalov@...ux.dev> wrote:
> >
> > From: Andrey Konovalov <andreyknvl@...il.com>
> >
> > Commit 29d7355a9d05 ("kasan: save alloc stack traces for mempool") messed
> > up one of the calls to unpoison_slab_object: the last two arguments are
> > supposed to be GFP flags and whether to init the object memory.
> >
> > Fix the call.
> >
> > Without this fix, unpoison_slab_object provides the object's size as
> > GFP flags to unpoison_slab_object, which can cause LOCKDEP reports
> > (and probably other issues).
> >
> > Fixes: 29d7355a9d05 ("kasan: save alloc stack traces for mempool")
> > Reported-by: Brad Spengler <spender@...ecurity.net>
> > Signed-off-by: Andrey Konovalov <andreyknvl@...il.com>
>
> Oof.
>
> Acked-by: Marco Elver <elver@...gle.com>
>
> mm needs explicit Cc: stable, right? If so, we better add Cc: stable as well.

Makes sense, sent v2 with CC stable and a commit message fix.

Thanks!