linux-kernel - Re: [PATCH 1/2] bcachefs: use FGP_WRITEBEGIN instead of combining individual flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZmxVZiveDdzyByTQ@casper.infradead.org>
Date: Fri, 14 Jun 2024 15:36:22 +0100
From: Matthew Wilcox <willy@...radead.org>
To: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
Cc: Brian Foster <bfoster@...hat.com>,
	Kent Overstreet <kent.overstreet@...ux.dev>,
	linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pankaj Raghav <p.raghav@...sung.com>
Subject: Re: [PATCH 1/2] bcachefs: use FGP_WRITEBEGIN instead of combining
 individual flags

On Fri, Jun 14, 2024 at 10:50:30AM +0000, Pankaj Raghav (Samsung) wrote:
>  	ret = bch2_filemap_get_contig_folios_d(mapping, pos, end,
> -				   FGP_LOCK|FGP_WRITE|FGP_STABLE|FGP_CREAT,
> -				   mapping_gfp_mask(mapping),
> -				   &fs);
> +					       FGP_WRITEBEGIN,
> +					       mapping_gfp_mask(mapping), &fs);

Don't change the indentation here.  In the next patch it makes the
lines too long.

In general, don't change the indentation.  It's been one of the biggest
pains of the folio conversion.  "Oh, you changed the name of this
function and now the arguments don't line up".  Don't line up the
arguments with the opening paren.