linux-kernel - Re: [PATCH] x86: pci: xen: Remove unnecessary ‘0’ values from ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 17:54:30 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Li zeming <zeming@...china.com>
cc: jgross@...e.com, bhelgaas@...gle.com, tglx@...utronix.de, mingo@...hat.com, 
    bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, 
    xen-devel@...ts.xenproject.org, linux-pci@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: pci: xen: Remove unnecessary ‘0’ values from ret

On Wed, 12 Jun 2024, Li zeming wrote:

> ret is assigned first, so it does not need to initialize the assignment.

While the patch seems fine, this description and the shortlog are
confusing.

-- 
 i.

> Signed-off-by: Li zeming <zeming@...china.com>
> ---
>  arch/x86/pci/xen.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index 652cd53e77f6..67cb9dc9b2e7 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -267,7 +267,7 @@ static bool __read_mostly pci_seg_supported = true;
>  
>  static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
>  {
> -	int ret = 0;
> +	int ret;
>  	struct msi_desc *msidesc;
>  
>  	msi_for_each_desc(msidesc, &dev->dev, MSI_DESC_NOTASSOCIATED) {
> @@ -353,7 +353,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
>  
>  bool xen_initdom_restore_msi(struct pci_dev *dev)
>  {
> -	int ret = 0;
> +	int ret;
>  
>  	if (!xen_initial_domain())
>  		return true;
>