linux-kernel - Re: [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABi2SkXcb_GaSomWrj+n8tEg-VmR3e5bLpqw0-h9K=6gkiBxow@mail.gmail.com>
Date: Fri, 14 Jun 2024 07:56:57 -0700
From: Jeff Xu <jeffxu@...omium.org>
To: David Hildenbrand <david@...hat.com>
Cc: John Hubbard <jhubbard@...dia.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Shuah Khan <shuah@...nel.org>, Andrei Vagin <avagin@...gle.com>, 
	Axel Rasmussen <axelrasmussen@...gle.com>, Christian Brauner <brauner@...nel.org>, 
	Kees Cook <kees@...nel.org>, Kent Overstreet <kent.overstreet@...ux.dev>, 
	"Liam R . Howlett" <Liam.Howlett@...cle.com>, Muhammad Usama Anjum <usama.anjum@...labora.com>, 
	Peter Xu <peterx@...hat.com>, Rich Felker <dalias@...c.org>, linux-mm@...ck.org, 
	linux-kselftest@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test
 macros and other duplicated items

On Fri, Jun 14, 2024 at 5:28 AM David Hildenbrand <david@...hat.com> wrote:
>
> On 14.06.24 04:30, John Hubbard wrote:
> > Clean up and move some copy-pasted items into a new mseal_helpers.h.
> >
> > 1. The test macros can be made safer and simpler, by observing that they
> > are invariably called when about to return. This means that the macros
> > do not need an intrusive label to goto; they can simply return.
> >
> > 2. PKEY* items. We cannot, unfortunately use pkey-helpers.h. The best we
> > can do is to factor out these few items into mseal_helpers.h.
> >
> > 3. These tests still need their own definition of u64, so also move that
> > to the header file.
> >
> > Cc: Jeff Xu <jeffxu@...omium.org>
> > Cc: David Hildenbrand <david@...hat.com>
> > Signed-off-by: John Hubbard <jhubbard@...dia.com>
> > ---
>
> Acked-by: David Hildenbrand <david@...hat.com>
Reviewed-by: Jeff Xu <jeffxu@...gle.com>

>
> --
> Cheers,
>
> David / dhildenb
>