linux-kernel - Re: [PATCH] ASoc: PCM6240: Fix a null pointer dereference in pcmdevice_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82283abf-10b1-4095-a93f-112ba8aca483@web.de>
Date: Sat, 15 Jun 2024 08:16:26 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Hao Ge <gehao@...inos.cn>, linux-sound@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Colin Ian King <colin.i.king@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Shenghao Ding <shenghao-ding@...com>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ASoc: PCM6240: Fix a null pointer dereference in
 pcmdevice_i2c_probe

…
> +++ b/sound/soc/codecs/pcm6240.c
> @@ -2088,8 +2088,7 @@ static int pcmdevice_i2c_probe(struct i2c_client *i2c)
>
>  	pcm_dev = devm_kzalloc(&i2c->dev, sizeof(*pcm_dev), GFP_KERNEL);
>  	if (!pcm_dev) {
> -		ret = -ENOMEM;
> -		goto out;
> +		return -ENOMEM;
>  	}
…

Would you like to omit curly brackets from a single if branch?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.10-rc3#n197

Regards,
Markus