linux-kernel - RE: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 19:59:11 +0530
From: "Alim Akhtar" <alim.akhtar@...sung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>, "'Daniel
 Lezcano'" <daniel.lezcano@...aro.org>, "'Zhang Rui'" <rui.zhang@...el.com>,
	"'Lukasz Luba'" <lukasz.luba@....com>, "'Rob Herring'" <robh@...nel.org>,
	"'Conor Dooley'" <conor+dt@...nel.org>, "'Guillaume La Roque'"
	<glaroque@...libre.com>, "'Krzysztof Kozlowski'" <krzk+dt@...nel.org>,
	"'Vasily Khoruzhick'" <anarsoul@...il.com>, "'Chen-Yu Tsai'"
	<wens@...e.org>, "'Jernej Skrabec'" <jernej.skrabec@...il.com>, "'Samuel
 Holland'" <samuel@...lland.org>, "'Shawn Guo'" <shawnguo@...nel.org>,
	"'Sascha Hauer'" <s.hauer@...gutronix.de>, "'Pengutronix	Kernel Team'"
	<kernel@...gutronix.de>, "'Fabio Estevam'" <festevam@...il.com>, "'Anson
 Huang'" <Anson.Huang@....com>, "'Thierry Reding'"
	<thierry.reding@...il.com>, "'Jonathan Hunter'" <jonathanh@...dia.com>,
	"'Dmitry	Baryshkov'" <dmitry.baryshkov@...aro.org>, "'Amit Kucheria'"
	<amitk@...nel.org>, 'Niklas Söderlund'
	<niklas.soderlund@...natech.se>, "'Heiko	Stuebner'" <heiko@...ech.de>,
	"'Biju Das'" <biju.das.jz@...renesas.com>, "'Orson	Zhai'"
	<orsonzhai@...il.com>, "'Baolin Wang'" <baolin.wang@...ux.alibaba.com>,
	"'Chunyan Zhang'" <zhang.lyra@...il.com>, "'Alexandre Torgue'"
	<alexandre.torgue@...s.st.com>, "'Pascal Paillet'" <p.paillet@...s.st.com>,
	"'Keerthy'" <j-keerthy@...com>, "'Broadcom internal kernel review list'"
	<bcm-kernel-feedback-list@...adcom.com>, "'Florian Fainelli'"
	<florian.fainelli@...adcom.com>, "'Scott Branden'" <sbranden@...adcom.com>,
	"'zhanghongchen'" <zhanghongchen@...ngson.cn>, "'Matthias Brugger'"
	<matthias.bgg@...il.com>, "'AngeloGioacchino Del Regno'"
	<angelogioacchino.delregno@...labora.com>, "'Bjorn Andersson'"
	<andersson@...nel.org>, "'Geert Uytterhoeven'" <geert+renesas@...der.be>
Cc: <linux-pm@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-amlogic@...ts.infradead.org>,
	<linux-sunxi@...ts.linux.dev>, <imx@...ts.linux.dev>,
	<linux-tegra@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>, <linux-rockchip@...ts.infradead.org>,
	<linux-stm32@...md-mailman.stormreply.com>, "'Florian Fainelli'"
	<f.fainelli@...il.com>, <linux-rpi-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>, <cpgs@...sung.com>
Subject: RE: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify
 cells

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Friday, June 14, 2024 3:16 PM
> To: Daniel Lezcano <daniel.lezcano@...aro.org
.stormreply.com;
> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells
> 
> All Samsung Exynos SoCs Thermal Management Units have only one sensor, so
> make '#thermal-sensor-cells' fixed at 0.
> 
This is not entirely true, there are SoCs which have multiple temp sensors.
It is true that currently only one sensor support is added though.

So we can leave this as is or you suggest to make it to support only one sensor
(to match the current DT support), and later (in near future) change it again to
match what HW actually support?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml | 3
> ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml
> index 1344df708e2d..29a08b0729ee 100644
> --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.y
> +++ aml
> @@ -61,7 +61,8 @@ properties:
>            TRIMINFO at 0x10068000 contains data for TMU channel 2
>      minItems: 1
> 
> -  '#thermal-sensor-cells': true
> +  '#thermal-sensor-cells':
> +    const: 0
> 
>    vtmu-supply:
>      description: The regulator node supplying voltage to TMU.
> 
> --
> 2.43.0