linux-kernel - Re: [PATCH] LoongArch: Define __ARCH_WANT_NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdef45d36d0e71da5f0534b3783b81c82405bda3.camel@xry111.site>
Date: Sat, 15 Jun 2024 16:55:08 +0800
From: Xi Ruoyao <xry111@...111.site>
To: Huacai Chen <chenhuacai@...nel.org>, Arnd Bergmann <arnd@...db.de>
Cc: Huacai Chen <chenhuacai@...ngson.cn>, loongarch@...ts.linux.dev,
 Linux-Arch <linux-arch@...r.kernel.org>, Xuefeng Li
 <lixuefeng@...ngson.cn>, guoren <guoren@...nel.org>, WANG Xuerui
 <kernel@...0n.name>, Jiaxun Yang <jiaxun.yang@...goat.com>,
 linux-kernel@...r.kernel.org,  loongson-kernel@...ts.loongnix.cn,
 stable@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Define __ARCH_WANT_NEW_STAT in unistd.h

On Sat, 2024-06-15 at 16:52 +0800, Huacai Chen wrote:
> Hi, Arnd,
> 
> On Sun, May 12, 2024 at 3:53 PM Arnd Bergmann <arnd@...db.de> wrote:
> > 
> > On Sun, May 12, 2024, at 05:11, Huacai Chen wrote:
> > > On Sat, May 11, 2024 at 11:39 PM Arnd Bergmann <arnd@...db.de> wrote:
> > > > On Sat, May 11, 2024, at 16:28, Huacai Chen wrote:
> > > > > On Sat, May 11, 2024 at 8:17 PM Arnd Bergmann <arnd@...db.de> wrote:
> > > > CONFIG_COMPAT_32BIT_TIME is equally affected here. On riscv32
> > > > this is the only allowed configuration, while on others (arm32
> > > > or x86-32 userland) you can turn off COMPAT_32BIT_TIME on
> > > > both 32-bit kernel and on 64-bit kernels with compat mode.
> > > I don't know too much detail, but I think riscv32 can do something
> > > similar to arm32 and x86-32, or we can wait for Xuerui to improve
> > > seccomp. But there is no much time for loongarch because the Debian
> > > loong64 port is coming soon.
> > 
> > What I meant is that the other architectures only work by
> > accident if COMPAT_32BIT_TIME is enabled and statx() gets
> > blocked, but then they truncate the timestamps to the tim32
> > range, which is not acceptable behavior. Actually mips64 is
> > in the same situation because it also only supports 32-bit
> > timestamps in newstatat(), despite being a 64-bit
> > architecture with a 64-bit time_t in all other syscalls.
> We can only wait for the seccomp side to be fixed now? Or we can get
> this patch upstream for LoongArch64 at the moment, and wait for
> seccomp to fix RISCV32 (and LoongArch32) in future?

I'm wondering why not just introduce a new syscall or extend statx with
a new flag, as we've discussed many times.  They have their own
disadvantages but better than this, IMO.

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University