linux-kernel - Re: [PATCH] KVM: fix an error code in kvm_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171840971654.1410787.550758149243431657.b4-ty@google.com>
Date: Fri, 14 Jun 2024 17:02:51 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>, Yi Wang <foxywang@...cent.com>, 
	Dan Carpenter <dan.carpenter@...aro.org>
Cc: Paolo Bonzini <pbonzini@...hat.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] KVM: fix an error code in kvm_create_vm()

On Thu, 13 Jun 2024 17:33:16 +0300, Dan Carpenter wrote:
> This error path used to return -ENOMEM from the where r is initialized
> at the top of the function.  But a new "r = kvm_init_irq_routing(kvm);"
> was introduced in the middle of the function so now the error code is
> not set and it eventually leads to a NULL dereference.  Set the error
> code back to -ENOMEM.
> 
> 
> [...]

Applied to kvm-x86 generic, with the fixup I suggested and a massaged changelog
to address Markus' feedback.  Thanks again!

[1/1] KVM: fix an error code in kvm_create_vm()
      https://github.com/kvm-x86/linux/commit/5c1f50ab7fcb

--
https://github.com/kvm-x86/linux/tree/next