linux-kernel - Re: [PATCH] fs: modify the annotation of vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240615030056.GO1629371@ZenIV>
Date: Sat, 15 Jun 2024 04:00:56 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Congjie Zhou <zcjie0802@...com>
Cc: linux-fsdevel@...r.kernel.org, brauner@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: modify the annotation of vfs_mkdir() in fs/namei.c

On Sat, Jun 15, 2024 at 09:59:13AM +0800, Congjie Zhou wrote:
> modify the annotation of @dir and @dentry


>   * vfs_mkdir - create directory
>   * @idmap:	idmap of the mount the inode was found from
> - * @dir:	inode of @dentry
> - * @dentry:	pointer to dentry of the base directory
> + * @dir:	inode of parent dentry of @dentry
> + * @dentry:	pointer to dentry of the new directory

Ugh...  How about 'inode of the parent directory' and 'dentry
of the child to be' instead?