linux-kernel - Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic on IdeaPad 330-17IKB 81DM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5jl5ocj.wl-tiwai@suse.de>
Date: Sun, 16 Jun 2024 09:38:36 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Ajrat Makhmutov <rautyrauty@...il.com>
Cc: alsa-devel@...a-project.org,
	perex@...ex.cz,
	tiwai@...e.com,
	kailang@...ltek.com,
	sbinding@...nsource.cirrus.com,
	luke@...nes.dev,
	shenghao-ding@...com,
	simont@...nsource.cirrus.com,
	foss@...aariq.my.id,
	rf@...nsource.cirrus.com,
	wzhd@...c.edu,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic on IdeaPad 330-17IKB 81DM

On Sat, 15 Jun 2024 14:54:57 +0200,
Ajrat Makhmutov wrote:
> 
> Headset microphone do not work out of the box with this laptop. This
> quirk fixes it. Zihao Wang specified the wrong subsystem id in his patch.
> 
> Link: https://lore.kernel.org/all/20220424084120.74125-1-wzhd@ustc.edu/
> Fixes: 3b79954fd00d ("ALSA: hda/realtek: Add quirk for Yoga Duet 7 13ITL6 speakers")
> Signed-off-by: Ajrat Makhmutov <rauty@...linux.org>

Your From address and Signed-off-by address are different.
Could you try to align them?

I can take as-is if inevitably necessary, but usually it's a wrong
sign.


thanks,

Takashi