linux-kernel - Re: [PATCH 05/12] dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RZ/G3S RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de1077de-baa4-42aa-84c1-6ab629088a07@kernel.org>
Date: Sun, 16 Jun 2024 09:40:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Claudiu <claudiu.beznea@...on.dev>, geert+renesas@...der.be,
 mturquette@...libre.com, sboyd@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, lee@...nel.org,
 alexandre.belloni@...tlin.com, magnus.damm@...il.com
Cc: linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH 05/12] dt-bindings: rtc: renesas,rzg3s-rtc: Document the
 Renesas RZ/G3S RTC

On 14/06/2024 09:19, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> 
> Document the RTC IP (RTCA-3) available on the Renesas RZ/G3S SoC.

> +
> +  clocks:
> +    maxItems: 1
> +    description: RTC counter clock

Just items: with description instead.

> +
> +  clock-names:
> +    maxItems: 1

Nope, it must be specifc. Or just drop. This applies to all your patches.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - clocks
> +  - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    rtc: rtc@...4ec00 {

Drop label, not used.

> +        compatible = "renesas,rzg3s-rtc";
> +        reg = <0x1004ec00 0x400>;
> +        interrupts = <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 316 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
> +        interrupt-names = "alarm", "period", "carry";
> +        clocks = <&vbattclk>;
> +        clock-names = "counter";
> +        status = "disabled";

Why do you paste it eevrywhere? It does no really make sense.

Best regards,
Krzysztof