[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNAQyPRKes7=wNtYXre+nU=5-1oZ-g1uzbjFMFd2e10jFjA@mail.gmail.com>
Date: Mon, 17 Jun 2024 00:21:15 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: linux-kbuild@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>,
Nicolas Schier <nicolas@...sle.eu>
Subject: Re: [PATCH 2/2] kbuild: package: add -e and -u options to shell scripts
On Wed, Jun 12, 2024 at 1:09 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> Set -e to make these scripts fail on the first error.
>
> Set -u because these scripts are invoked by Makefile, and do not work
> properly without necessary variables defined.
>
> Remove the explicit "test -n ..." from scripts/package/install-extmod-build.
>
> Both options are described in POSIX. [1]
>
> [1]: https://pubs.opengroup.org/onlinepubs/009604499/utilities/set.html
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
Setting -u needs more careful review and test.
This patch will break 'make deb-pkg'.
./scripts/package/mkdebian: 150: KDEB_PKGVERSION: parameter not set
To set -u, scripts/package/mkdebian needs code refactoring.
I will keep scripts/package/mkdebian untouched.
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists