linux-kernel - Re: [PATCH] EDAC: layerscape: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 16 Jun 2024 17:43:47 +0200
From: Borislav Petkov <bp@...en8.de>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Tony Luck <tony.luck@...el.com>, James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] EDAC: layerscape: add missing MODULE_DESCRIPTION() macro

On Thu, Jun 13, 2024 at 02:36:21PM -0700, Jeff Johnson wrote:
> With ARCH=arm64, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/edac/layerscape_edac_mod.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  drivers/edac/layerscape_edac.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/edac/layerscape_edac.c b/drivers/edac/layerscape_edac.c
> index d2f895033280..b70d5d258fcb 100644
> --- a/drivers/edac/layerscape_edac.c
> +++ b/drivers/edac/layerscape_edac.c
> @@ -69,6 +69,7 @@ static void __exit fsl_ddr_mc_exit(void)
>  
>  module_exit(fsl_ddr_mc_exit);
>  
> +MODULE_DESCRIPTION("Freescale Layerscape EDAC module");
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("NXP Semiconductor");
>  module_param(edac_op_state, int, 0444);
> 
> ---

$ git grep -E "MODULE_(DESCRIPTION|LICENSE)" drivers/edac/

I'd expect to see regular pairs like this:

drivers/edac/al_mc_edac.c:348:MODULE_LICENSE("GPL v2");
drivers/edac/al_mc_edac.c:350:MODULE_DESCRIPTION("Amazon's Annapurna Lab's Memory Controller EDAC Driver");

drivers/edac/altera_edac.c:2216:MODULE_DESCRIPTION("EDAC Driver for Altera Memories");

drivers/edac/amd64_edac.c:4238:MODULE_LICENSE("GPL");
drivers/edac/amd64_edac.c:4240:MODULE_DESCRIPTION("MC support for AMD64 memory controllers");
...

but there are cases which need fixing.

How about you do them all with one patch?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette