linux-kernel - Re: [PATCH net-next 2/2] net: dsa: mt7530: add support for bridge port isolation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 16 Jun 2024 18:35:25 +0200
From: Matthias Schiffer <mschiffer@...verse-factory.net>
To: Andrew Lunn <andrew@...n.ch>
Cc: Arınç ÜNAL <arinc.unal@...nc9.com>,
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Daniel Golle <daniel@...rotopia.org>, DENG Qingfang <dqfext@...il.com>,
 Sean Wang <sean.wang@...iatek.com>
Subject: Re: [PATCH net-next 2/2] net: dsa: mt7530: add support for bridge
 port isolation

On 16/06/2024 17:35, Andrew Lunn wrote:
>> As far as I can tell, the rules are:
>>
>> - non-isolated ports can communicate with every port
>> - isolated ports can't communicate with other isolated ports
>> - communication is symmetric
> 
> It is a bit more subtle than that.
> 
> By default, all ports should be isolated. They can exchange packets
> with the CPU port, but nothing else. This goes back to the model of
> switches just look like a bunch of netdev interfaces. By default,
> linux netdev interfaces are standalone. You need to add a bridge
> before packets can flow between ports.
> 
> Once you add a bridge, ports within that bridge can exchange
> packets. However, there can be multiple bridges. So a port needs to be
> isolated from ports in another bridge, but non-isolated to ports
> within the same bridge.
> 
>         Andrew

Right, I was talking about ports in the same bridge (which is already 
handled as expected by the mt7530 driver, just the option to set the 
isolation flag for individual bridge ports was unsupported).

Matthias

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)