linux-kernel - Re: [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e1dd5d1-8c5d-44f5-99e8-f42cfbdeee04@web.de>
Date: Sun, 16 Jun 2024 18:38:58 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
 Mohammad Rafi Shaik <quic_mohs@...cinc.com>,
 Prasad Kumpatla <quic_pkumpatl@...cinc.com>, alsa-devel@...a-project.org,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, Banajit Goswami <bgoswami@...cinc.com>,
 Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Takashi Iwai <tiwai@...e.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Rohit kumar <quic_rohkumar@...cinc.com>
Subject: Re: [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver

> This patch adds basic SoundWire codec driver to support for
> WCD9370/WCD9375 TX and RX devices.
…

Please improve such a change description with an imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94


…
> +++ b/sound/soc/codecs/wcd937x.c
> @@ -0,0 +1,1677 @@
…
> +static int wcd937x_mbhc_micb_adjust_voltage(struct snd_soc_component *component,
> +					    int req_volt, int micb_num)
> +{
…
> +	mutex_lock(&wcd937x->micb_lock);
> +	/*
> +	 * If requested micbias voltage is same as current micbias
…
> +exit:
> +	mutex_unlock(&wcd937x->micb_lock);
> +	return ret;
> +}
…

Would you become interested to apply a statement like “guard(mutex)(&wcd937x->micb_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196

Regards,
Markus