linux-kernel - Re: [PATCH 1/6] dt-bindings: clock: Document T-Head TH1520 AP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240616-reaffirm-thud-e3fb4de33d7f@spud>
Date: Sun, 16 Jun 2024 19:38:21 +0100
From: Conor Dooley <conor@...nel.org>
To: Drew Fustini <dfustini@...storrent.com>
Cc: Jisheng Zhang <jszhang@...nel.org>, Guo Ren <guoren@...nel.org>,
	Fu Wei <wefu@...hat.com>, Yangtao Li <frank.li@...o.com>,
	Thomas Bonnefille <thomas.bonnefille@...tlin.com>,
	Emil Renner Berthing <emil.renner.berthing@...onical.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, linux-riscv@...ts.infradead.org,
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS
 controller

On Sat, Jun 15, 2024 at 06:54:30PM -0700, Drew Fustini wrote:
> +examples:
> +  - |
> +    #include <dt-bindings/clock/thead,th1520-clk-ap.h>
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +
> +      clock-controller@...f010000 {
> +        compatible = "thead,th1520-clk-ap";
> +        reg = <0xff 0xef010000 0x0 0x1000>;

Drop the 2 cell stuff here, it's not needed in the example.

Otherwise, looks okay to me.
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> +        clocks = <&osc>;
> +        #clock-cells = <1>;
> +      };
> +    };

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)