linux-kernel - Re: [PATCH v2 net] ptp: fix integer overflow in max_vclocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnA71MTiaESQTUMp@nanopsycho.orion>
Date: Mon, 17 Jun 2024 15:36:20 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Yangbo Lu <yangbo.lu@....com>,
	Richard Cochran <richardcochran@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v2 net] ptp: fix integer overflow in max_vclocks_store

Mon, Jun 17, 2024 at 11:34:32AM CEST, dan.carpenter@...aro.org wrote:
>On 32bit systems, the "4 * max" multiply can overflow.  Use kcalloc()
>to do the allocation to prevent this.
>
>Fixes: 44c494c8e30e ("ptp: track available ptp vclocks information")
>Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>