| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<ZQ0PR01MB125399D22E07CACF6E9CF39B9FCD2@ZQ0PR01MB1253.CHNPR01.prod.partner.outlook.cn>
Date: Mon, 17 Jun 2024 02:36:33 +0000
From: William Qiu <william.qiu@...rfivetech.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>, Hal Feng
<hal.feng@...rfivetech.com>, Philipp Zabel <p.zabel@...gutronix.de>
Subject: RE: [PATCH v12] pwm: opencores: Add PWM driver support
> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> Sent: 2024年6月14日 18:37
> To: William Qiu <william.qiu@...rfivetech.com>
> Cc: linux-kernel@...r.kernel.org; linux-pwm@...r.kernel.org; Hal Feng
> <hal.feng@...rfivetech.com>; Philipp Zabel <p.zabel@...gutronix.de>
> Subject: Re: [PATCH v12] pwm: opencores: Add PWM driver support
>
> Hello William,
>
> thanks for your patience and sorry for taking so long until I came around to
> review this.
>
> On Mon, Apr 29, 2024 at 03:51:40PM +0800, William Qiu wrote:
> > diff --git a/drivers/pwm/pwm-ocores.c b/drivers/pwm/pwm-ocores.c new
> > file mode 100644 index 000000000000..039fb3c526a7
> > --- /dev/null
> > +++ b/drivers/pwm/pwm-ocores.c
> > @@ -0,0 +1,240 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * OpenCores PWM Driver
> > + *
> > + * https://opencores.org/projects/ptc
> > + *
> > + * Copyright (C) 2018-2023 StarFive Technology Co., Ltd.
> > + *
> > + * Limitations:
> > + * - The hardware only do inverted polarity.
>
> s/do/does/
>
Will update.
> > + * - The hardware minimum period / duty_cycle is (1 / pwm_apb clock
> frequency) ns.
> > + * - The hardware maximum period / duty_cycle is (U32_MAX / pwm_apb
> clock frequency) ns.
>
> How does the hardware behave on disable? Does it complete the currently
> running period when reconfiguring or disabling? Are glitches expected in .apply()?
> Please answer these questions in the Limitations paragraph.
>
Will update.
> > + */
> > +
> > +#include <linux/clk.h>
> > +#include <linux/io.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/pwm.h>
> > +#include <linux/reset.h>
> > +#include <linux/slab.h>
> > +
> > +/* OpenCores Register offsets */
> > +#define REG_OCPWM_CNTR 0x0
> > +#define REG_OCPWM_HRC 0x4
> > +#define REG_OCPWM_LRC 0x8
> > +#define REG_OCPWM_CTRL 0xC
> > +
> > +/* OCPWM_CTRL register bits*/
> > +#define REG_OCPWM_EN BIT(0)
>
> I would prefer this one to be called REG_OCPWM_CNTR_EN. Ditto for the
> following definitions.
>
Will update.
> > +#define REG_OCPWM_ECLK BIT(1)
> > +#define REG_OCPWM_NEC BIT(2)
> > +#define REG_OCPWM_OE BIT(3)
> > +#define REG_OCPWM_SIGNLE BIT(4)
> > +#define REG_OCPWM_INTE BIT(5)
> > +#define REG_OCPWM_INT BIT(6)
> > +#define REG_OCPWM_CNTRRST BIT(7)
> > +#define REG_OCPWM_CAPTE BIT(8)
> > +
> > [...]
> > +static int ocores_pwm_apply(struct pwm_chip *chip,
> > + struct pwm_device *pwm,
> > + const struct pwm_state *state) {
> > + struct ocores_pwm_device *ddata = chip_to_ocores(chip);
> > + u32 ctrl_data = 0;
> > + u64 period_data, duty_data;
> > +
> > + if (state->polarity != PWM_POLARITY_INVERSED)
> > + return -EINVAL;
> > +
> > + ctrl_data = ocores_pwm_readl(ddata, pwm->hwpwm,
> REG_OCPWM_CTRL);
> > + ocores_pwm_writel(ddata, pwm->hwpwm, REG_OCPWM_CTRL, 0);
> > +
> > + period_data = mul_u64_u32_div(state->period, ddata->clk_rate,
> NSEC_PER_SEC);
> > + if (period_data > U32_MAX)
> > + period_data = U32_MAX;
>
> This assignment is useless, the value of period_data isn't used later,
>
> I think you want:
>
> period_data = ...
>
> if (!period_data)
> return -EINVAL
>
> if (period_data > U32_MAX)
> period_data = U32_MAX;
>
> ocores_pwm_writel(ddata, pwm->hwpwm, 0x8, (u32)period_data);
>
>
I'll try it then.
> > + else if (period_data > 0)
> > + ocores_pwm_writel(ddata, pwm->hwpwm, 0x8, (u32)period_data);
> > + else
> > + return -EINVAL;
> > +
> > + duty_data = mul_u64_u32_div(state->duty_cycle, ddata->clk_rate,
> NSEC_PER_SEC);
> > + if (duty_data <= U32_MAX)
> > + ocores_pwm_writel(ddata, pwm->hwpwm, REG_OCPWM_HRC,
> (u32)duty_data);
> > + else
> > + return -EINVAL;
>
> duty_data > U32_MAX should be handled in the same way as period_data >
> U32_MAX.
>
> > + ocores_pwm_writel(ddata, pwm->hwpwm, REG_OCPWM_CNTR, 0);
> > +
> > + if (state->enabled) {
> > + ctrl_data = ocores_pwm_readl(ddata, pwm->hwpwm,
> REG_OCPWM_CTRL);
> > + ocores_pwm_writel(ddata, pwm->hwpwm, REG_OCPWM_CTRL,
> > + ctrl_data | REG_OCPWM_EN | REG_OCPWM_OE);
> > + }
>
> Wouldn't it make sense to unset REG_OCPWM_EN | REG_OCPWM_OE if
> (!state->enabled)?
>
Will update.
> > + return 0;
> > +}
> > +
> > +static const struct pwm_ops ocores_pwm_ops = {
> > + .get_state = ocores_pwm_get_state,
> > + .apply = ocores_pwm_apply,
>
> In other structs you're using a single space before =. I'd prefer that here, too.
>
Will add.
> > +};
> > +
> > +static const struct ocores_pwm_data jh7100_pwm_data = {
> > + .get_ch_base = starfive_jh71x0_get_ch_base, };
> > +
> > +static const struct ocores_pwm_data jh7110_pwm_data = {
> > + .get_ch_base = starfive_jh71x0_get_ch_base, };
>
> These two are identical. Does it make sense to use only one instance of these?
>
Will update.
> > [...]
> > +static int ocores_pwm_probe(struct platform_device *pdev) {
> > + const struct of_device_id *id;
> > + struct device *dev = &pdev->dev;
> > + struct ocores_pwm_device *ddata;
> > + struct pwm_chip *chip;
> > + struct clk *clk;
> > + struct reset_control *rst;
> > + int ret;
> > +
> > + id = of_match_device(ocores_pwm_of_match, dev);
> > + if (!id)
> > + return -EINVAL;
> > +
> > + chip = devm_pwmchip_alloc(&pdev->dev, 8, sizeof(*ddata));
> > + if (IS_ERR(chip))
> > + return -ENOMEM;
> > +
> > + ddata = chip_to_ocores(chip);
> > + ddata->data = id->data;
> > + chip->ops = &ocores_pwm_ops;
> > +
> > + ddata->regs = devm_platform_ioremap_resource(pdev, 0);
> > + if (IS_ERR(ddata->regs))
> > + return dev_err_probe(dev, PTR_ERR(ddata->regs),
> > + "Unable to map IO resources\n");
> > +
> > + clk = devm_clk_get_enabled(dev, NULL);
> > + if (IS_ERR(clk))
> > + return dev_err_probe(dev, PTR_ERR(clk),
> > + "Unable to get pwm's clock\n");
> > +
> > + ret = devm_clk_rate_exclusive_get(dev, clk);
> > + if (ret)
> > + return ret;
> > +
> > + rst = devm_reset_control_get_optional_exclusive(dev, NULL);
> > + if (IS_ERR(rst))
> > + return dev_err_probe(dev, PTR_ERR(rst),
> > + "Unable to get pwm's reset\n");
> > +
> > + reset_control_deassert(rst);
> > +
> > + ret = devm_add_action_or_reset(dev, ocores_pwm_reset_control_assert,
> rst);
> > + if (ret)
> > + return ret;
> > +
> > + ddata->clk_rate = clk_get_rate(clk);
> > + if (ddata->clk_rate <= 0 || ddata->clk_rate > NSEC_PER_SEC)
>
> clk_rate is an u32. So ddata->clk_rate <= 0 will never be true. Also on 64bit
> archs clk_get_rate() might return 4294967297 which results in
> ddata->clk_rate being assigned 1 and then passing this test.
>
Will fix it.
> > + return dev_err_probe(dev, ddata->clk_rate,
> > + "Unable to get clock's rate\n");
> > +
> > + ret = devm_pwmchip_add(dev, chip);
> > + if (ret < 0)
> > + return dev_err_probe(dev, ret, "Could not register PWM chip\n");
> > +
> > + return 0;
> > +}
>
> Best regards
> Uwe
Thank you for taking time to review this patch.
Best Regards
William
Powered by blists - more mailing lists