linux-kernel - Re: [PATCH PATCH 3/9] perf/x86/intel: Use topology_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c4978b4-ac69-480e-b8cf-a473b64ed917@intel.com>
Date: Mon, 17 Jun 2024 07:50:53 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 x86@...nel.org
Cc: daniel.sneddon@...ux.intel.com, tony.luck@...el.com,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-perf-users@...r.kernel.org, Josh Poimboeuf <jpoimboe@...nel.org>,
 Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>,
 Andrew Cooper <andrew.cooper3@...rix.com>
Subject: Re: [PATCH PATCH 3/9] perf/x86/intel: Use topology_cpu_type() to get
 cpu-type

On 6/17/24 02:11, Pawan Gupta wrote:
> find_hybrid_pmu_for_cpu() uses get_this_hybrid_cpu_type() to get the CPU
> type, but it returns an invalid cpu-type when X86_FEATURE_HYBRID_CPU is not
> set. Some hybrid variants do enumerate cpu-type regardless of
> X86_FEATURE_HYBRID_CPU.

I'm not fully sure what point this is trying to make.

Is this trying to make the case that get_this_hybrid_cpu_type() and
topology_cpu_type() are equivalent or pointing out a difference?