linux-kernel - Re: [PATCH v5 2/3] dt-bindings:iio:proximity: Add hx9023s binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 17 Jun 2024 22:51:18 +0800
From: Yasin Lee <yasin.lee.x@...look.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-iio@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Yasin Lee <yasin.lee.x@...il.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v5 2/3] dt-bindings:iio:proximity: Add hx9023s binding


On 2024/6/16 16:40, Rob Herring (Arm) wrote:
> On Sun, 16 Jun 2024 15:36:48 +0800, Yasin Lee wrote:
>> From: Yasin Lee <yasin.lee.x@...il.com>
>>
>> A capacitive proximity sensor
>>
>> Signed-off-by: Yasin Lee <yasin.lee.x@...il.com>
>> ---
>>   .../bindings/iio/proximity/tyhx,hx9023s.yaml       | 98 ++++++++++++++++++++++
>>   1 file changed, 98 insertions(+)
>>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml:
> Error in referenced schema matching $id: http://devicetree.org/schemas/iio/proximity/adc.yaml
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:35.15-25: Warning (reg_format): /example-0/i2c/proximity@...channel@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:39.15-25: Warning (reg_format): /example-0/i2c/proximity@...channel@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:43.15-25: Warning (reg_format): /example-0/i2c/proximity@...channel@2:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:47.15-25: Warning (reg_format): /example-0/i2c/proximity@...channel@3:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:51.15-25: Warning (reg_format): /example-0/i2c/proximity@...channel@4:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:34.23-37.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@0: Relying on default #address-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:34.23-37.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@0: Relying on default #size-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:38.23-41.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@1: Relying on default #address-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:38.23-41.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@1: Relying on default #size-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:42.23-45.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@2: Relying on default #address-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:42.23-45.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@2: Relying on default #size-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:46.23-49.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@3: Relying on default #address-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:46.23-49.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@3: Relying on default #size-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:50.23-53.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@4: Relying on default #address-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dts:50.23-53.15: Warning (avoid_default_addr_size): /example-0/i2c/proximity@...channel@4: Relying on default #size-cells value
> Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: proximity@2a: channel@0: False schema does not allow {'reg': [[0]], 'input-channel': [[0]]}
> 	from schema $id: http://devicetree.org/schemas/iio/proximity/tyhx,hx9023s.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: proximity@2a: channel@1: False schema does not allow {'reg': [[1]], 'input-channel': [[1]]}
> 	from schema $id: http://devicetree.org/schemas/iio/proximity/tyhx,hx9023s.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: proximity@2a: channel@2: False schema does not allow {'reg': [[2]], 'input-channel': [[2]]}
> 	from schema $id: http://devicetree.org/schemas/iio/proximity/tyhx,hx9023s.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: proximity@2a: channel@3: False schema does not allow {'reg': [[3]], 'diff-channels': [[1, 0]]}
> 	from schema $id: http://devicetree.org/schemas/iio/proximity/tyhx,hx9023s.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.example.dtb: proximity@2a: channel@4: False schema does not allow {'reg': [[4]], 'diff-channels': [[2, 0]]}
> 	from schema $id: http://devicetree.org/schemas/iio/proximity/tyhx,hx9023s.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/SN7PR12MB810142C58543160AB45D07B3A4CC2@SN7PR12MB8101.namprd12.prod.outlook.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Thank you for your reply. I have corrected the errors according to your 
suggestions and will include the updates in version 6.

Yasin