linux-kernel - Re: [RFT PATCH] hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90f20e62-9200-4169-9415-3b74da92d640@roeck-us.net>
Date: Mon, 17 Jun 2024 07:58:21 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Armin Wolf <W_Armin@....de>
Cc: linux-hwmon@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	René Rebe <rene@...ctcode.de>,
	Thomas Weißschuh <linux@...ssschuh.net>,
	Stephen Horvath <s.horvath@...look.com.au>,
	Paul Menzel <pmenzel@...gen.mpg.de>,
	Sasha Kozachuk <skozachuk@...gle.com>,
	John Hamrick <johnham@...gle.com>
Subject: Re: [RFT PATCH] hwmon: (spd5118) Add support for Renesas/ITD SPD5118
 hub controllers

On Mon, Jun 17, 2024 at 12:50:41AM +0200, Armin Wolf wrote:
[ ... ]
> > 
> > This results in
> > 
> > spd5118 0-0050: Range 0: selector for 1 in window
> > spd5118 0-0050: error -EINVAL: regmap init failed
> > 
> > If you have an idea how to configure the ranges differently,
> > please let me know.
> > 
> > Thanks,
> > Guenter
> > 
> Oh, i did not think of this. In this case we indeed cannot use regmap here. I will test the patch tomorrow.
> 

That would be great. As for using regmap for paging, it actually
works if I remove the selector restrictions. I'll try to get the
restrictions removed or relaxed, but that will take some time. I'd
like to keep this patch separate from that effort. If it succeeds,
I'll send a follow-up patch to introduce regmap based paging.

Thanks,
Guenter