linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7eb6b3b-13b5-4587-a2f1-83fe3b30dc21@kernel.org>
Date: Mon, 17 Jun 2024 17:51:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kamlesh Gurudasani <kamlesh@...com>, Nishanth Menon <nm@...com>,
 Vignesh Raghavendra <vigneshr@...com>
Cc: Tero Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jayesh Choudhary <j-choudhary@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator

On 17/06/2024 12:22, Kamlesh Gurudasani wrote:
> Add the node for sa3ul crypto accelerator.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index ce4a2f105630..298d0c91fc0a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -216,6 +216,18 @@ k3_reset: reset-controller {
>  		};
>  	};
>  
> +	crypto: crypto@...00000 {
> +		compatible = "ti,am62-sa3ul";
> +		reg = <0x00 0x40900000 0x00 0x1200>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;

Why do you need ranges? No children here.

Anyway, keep the order as in DTS coding style.


Best regards,
Krzysztof