linux-kernel - Re: [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 21:30:11 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>,
 alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org
Cc: LKML <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
 Chancel Liu <chancel.liu@....com>, Conor Dooley <conor+dt@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>,
 Jonathan Downing <jonathan.downing@...tel.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Michael Ellerman <mpe@...erman.id.au>, Rob Herring <robh@...nel.org>,
 Russell King <linux@...linux.org.uk>, Takashi Iwai <tiwai@...e.com>,
 Vladimir Zapolskiy <vz@...ia.com>
Subject: Re: [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx
 CPUs

I suggest to specify email addresses for message recipients not only
in the header field “Cc”.


…
> +++ b/sound/soc/fsl/lpc3xxx-i2s.c
> @@ -0,0 +1,393 @@
…
> +static int lpc3xxx_i2s_startup(struct snd_pcm_substream *substream, struct snd_soc_dai *cpu_dai)
> +{
…
> +	int ret = 0;
> +
> +	mutex_lock(&i2s_info_p->lock);
…
> +lpc32xx_unlock:
> +	mutex_unlock(&i2s_info_p->lock);
> +	return ret;
> +}
…

Would you become interested to apply a statement like “guard(mutex)(&i2s_info_p->lock);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196

Regards,
Markus