linux-kernel - Shuah, Andy L: [PATCH v3 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 13:15:49 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Shuah Khan <shuah@...nel.org>
CC: "Jason A . Donenfeld" <Jason@...c4.com>, Andy Lutomirski
	<luto@...nel.org>, Mark Brown <broonie@...nel.org>, Vincenzo Frascino
	<vincenzo.frascino@....com>, Colin Ian King <colin.i.king@...il.com>,
	Valentin Obst <kernel@...entinobst.de>, <linux-kselftest@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, <llvm@...ts.linux.dev>, Thomas Gleixner
	<tglx@...utronix.de>, Carlos Llamas <cmllamas@...gle.com>
Subject: Shuah, Andy L: [PATCH v3 0/3] selftests/vDSO: fix clang build errors,
 and Makefile cleanup

On 6/14/24 4:34 PM, John Hubbard wrote:
> On 6/14/24 4:31 PM, John Hubbard wrote:
>> Hi,
>>
>> Jason A. Donenfeld, I've added you because I ended up looking through
>> your latest "implement getrandom() in vDSO" series [1], which also
>> touches this Makefile, so just a heads up about upcoming (minor) merge
>> conflicts.
> 
> Belatedly adding Carlos Llamas and Thomas Gleixner to Cc.
  
Hi Shuah, Andy, Thomas,

Patches 2 and 3 fix up the Makefile, and I'm particularly eager to get
those merged into 6.10, because the existing Makefile is leading people
astray. See the thread in [2] for an example of that.

As a result, Jason Donenfeld is now waiting for this, for his "implement
getrandom() in vDSO" series.

The Makefile is more of a kselftest infrastructure thing in a way, so
maybe Shuah can pull this in? I'm casting about for ways to move forward.

[2] https://lore.kernel.org/13483c92-cac5-4a3a-891f-22eb006c533b@nvidia.com


thanks,
-- 
John Hubbard
NVIDIA

>>
>> Changes since v2:
>>
>> 1. Added two patches, both of which apply solely to the Makefile.
>> These provide a smaller, cleaner, and more accurate Makefile.
>>
>> 2. Added Reviewed-by and Tested-by tags for the original patch, which
>> fixes all of the clang errors and warnings for this selftest.
>>
>> 3. Removed an obsolete blurb from the commit description of the original
>> patch, now that Valentin Obst LLVM build fix has been merged.
>>
>>
>> [1] https://lore.kernel.org/20240614190646.2081057-1-Jason@zx2c4.com
>>
>>
>> John Hubbard (3):
>>    selftests/vDSO: fix clang build errors and warnings
>>    selftests/mm: remove partially duplicated "all:" target in Makefile
>>    selftests/vDSO: remove duplicate compiler invocations from Makefile
>>
>>   tools/testing/selftests/vDSO/Makefile         | 29 ++++++++-----------
>>   tools/testing/selftests/vDSO/parse_vdso.c     | 16 ++++++----
>>   .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++++++++++--
>>   3 files changed, 39 insertions(+), 24 deletions(-)
>>
>>
>> base-commit: 2ccbdf43d5e758f8493a95252073cf9078a5fea5
> 
> thanks,