linux-kernel - Re: [PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ+vNU0F4n4Hfu=ZL5Mu3Nsk3vh4Y3iuH5funvshrkhQZD+b0Q@mail.gmail.com>
Date: Mon, 17 Jun 2024 16:00:38 -0700
From: Tim Harvey <tharvey@...eworks.com>
To: Marcel Holtmann <marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Scott Ehlert <ehlert@...telle.org>
Subject: Re: [PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373

On Mon, May 13, 2024 at 9:22 AM Tim Harvey <tharvey@...eworks.com> wrote:
>
> From: Scott Ehlert <ehlert@...telle.org>
>
> CYW4373 devices soldered onto the PCB (non-removable),
> use a UART connection for Bluetooth and the advertised btsdio
> support as an SDIO function should be ignored.
>
> Signed-off-by: Scott Ehlert <ehlert@...telle.org>
> Signed-off-by: Tim Harvey <tharvey@...eworks.com>
> ---
>  drivers/bluetooth/btsdio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
> index f19d31ee37ea..bc9631bddc40 100644
> --- a/drivers/bluetooth/btsdio.c
> +++ b/drivers/bluetooth/btsdio.c
> @@ -298,6 +298,7 @@ static int btsdio_probe(struct sdio_func *func,
>                 case SDIO_DEVICE_ID_BROADCOM_4345:
>                 case SDIO_DEVICE_ID_BROADCOM_43455:
>                 case SDIO_DEVICE_ID_BROADCOM_4356:
> +               case SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373:
>                         return -ENODEV;
>                 }
>         }
> --
> 2.25.1
>

Greetings,

It seems that this patch got archived due to failure of an automated
test. The failure doesn't appear to me to have anything to do with the
code change or perhaps I'm just not understanding the error:
https://patchwork.kernel.org/project/bluetooth/patch/20240513162200.2658571-1-tharvey@gateworks.com/

Is there something I need to do here?

Best Regards,

Tim