linux-kernel - Re: [PATCH] LoongArch: Define __ARCH_WANT_NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b783ee7b-1d27-4793-91cc-ff9d3f4f2103@app.fastmail.com>
Date: Mon, 17 Jun 2024 08:53:15 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Xi Ruoyao" <xry111@...111.site>, "Huacai Chen" <chenhuacai@...nel.org>
Cc: "Huacai Chen" <chenhuacai@...ngson.cn>, loongarch@...ts.linux.dev,
 Linux-Arch <linux-arch@...r.kernel.org>,
 "Xuefeng Li" <lixuefeng@...ngson.cn>, guoren <guoren@...nel.org>,
 "WANG Xuerui" <kernel@...0n.name>, "Jiaxun Yang" <jiaxun.yang@...goat.com>,
 linux-kernel@...r.kernel.org, loongson-kernel@...ts.loongnix.cn,
 stable@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Define __ARCH_WANT_NEW_STAT in unistd.h

On Mon, Jun 17, 2024, at 08:45, Xi Ruoyao wrote:
> On Mon, 2024-06-17 at 08:35 +0200, Arnd Bergmann wrote:
>> On Sat, Jun 15, 2024, at 15:12, Xi Ruoyao wrote:
>> > On Sat, 2024-06-15 at 20:12 +0800, Xi Ruoyao wrote:
>> > > 
>> > > [Firefox]:
>> > > https://searchfox.org/mozilla-central/source/security/sandbox/linu
>> > > x/SandboxFilter.cpp#364
>> > 
>> > Just spent some brain cycles to make a quick hack adding a new statx
>> > flag.  Patch attached.
>> > 
>> 
>> Thanks for the prototype. I agree that this is not a good API
>
> What is particular bad with it?  Maybe we can improve before annoying
> VFS guys :).

I can't come up with anything better either, the problem I
see is mainly that the man page has to explain both AT_EMPTY_PATH
and AT_FORCE_EMPTY_PATH, which are very similar for compatibility
reasons only. We would clearly not design a new interface to have
both, but we can't change existing behavior either.

       Arnd