linux-kernel - Re: [PATCH 1/3] dt-bindings: pinctrl: aspeed: Use block syntax for function and groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bf8e1dddd2b958a102e7b1b9f9c080a34f9deff.camel@codeconstruct.com.au>
Date: Mon, 17 Jun 2024 16:51:00 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
 linux-aspeed@...ts.ozlabs.org,  openbmc@...ts.ozlabs.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: aspeed: Use block syntax for
 function and groups

Hi Linus,

On Wed, 2024-06-05 at 10:17 +0930, Andrew Jeffery wrote:
> On Tue, 2024-06-04 at 14:27 -0500, Rob Herring wrote:
> > On Fri, May 31, 2024 at 12:32:47PM +0930, Andrew Jeffery wrote:
> > > The expansion makes the documents a lot longer, but it's easier to
> > > review changes to functions and groups when we're not having to deal
> > > with line wrapping.
> > 
> > Do you really expect to be updating this frequently? I would leave it 
> > as-is, but whatever you decide.
> 
> I don't expect to be updating it frequently. However it's happened
> occasionally in the past and the diff chaos irks me. So I prefer we
> explode it.
> 
> > 
> > > Signed-off-by: Andrew Jeffery <andrew@...econstruct.com.au>
> > > ---
> > 
> > Acked-by: Rob Herring (Arm) <robh@...nel.org>
> 
> Thanks.
> 

Are you okay to apply these (I see they're not yet in linux-pinctrl.git
for-next)? Turns out there's another concern lurking in the AST2600
RMII pin groups[1], and it would be nice if we could rework the patch
for that on top of this series.

[1]: https://lore.kernel.org/linux-gpio/20240613080725.2531580-1-potin.lai.pt@gmail.com/

Andrew