linux-kernel - Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88cbb88a-34de-4f97-9035-b3ef630580ed@ideasonboard.com>
Date: Mon, 17 Jun 2024 10:43:44 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Sean Anderson <sean.anderson@...ux.dev>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Michal Simek <michal.simek@....com>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in
 zynqmp_dpsub_probe()

Hi,

On 16/06/2024 21:43, Laurent Pinchart wrote:
> On Thu, Jun 13, 2024 at 11:05:01AM -0400, Sean Anderson wrote:
>> On 5/20/24 11:05, Sean Anderson wrote:
>>> On 5/20/24 05:40, Christophe JAILLET wrote:
>>>> If zynqmp_dpsub_drm_init() fails, we must undo the previous
>>>> drm_bridge_add() call.
>>>>
>>>> Fixes: be3f3042391d ("drm: zynqmp_dpsub: Always register bridge")
>>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>>>> ---
>>>> Compile tested only
>>>> ---
>>>>   drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>>>> index face8d6b2a6f..f5781939de9c 100644
>>>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>>>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>>>> @@ -269,6 +269,7 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev)
>>>>   	return 0;
>>>>   
>>>>   err_disp:
>>>> +	drm_bridge_remove(dpsub->bridge);
>>>>   	zynqmp_disp_remove(dpsub);
>>>>   err_dp:
>>>>   	zynqmp_dp_remove(dpsub);
>>>
>>> Reviewed-by: Sean Anderson <sean.anderso@...ux.dev>
>>
>> Will this be applied soon? The patch it fixes has made its way into
>> the stable tree already.
> 
> If someone can merge it in drm-misc that would be the fastest way.
> Otherwise I'll send a pull request at some point, but I'm overworked at
> the moment.
> 

Thanks, I have pushed this to drm-misc-next.

  Tomi