linux-kernel - Re: [PATCH v1 7/9] riscv: dts: add initial SpacemiT K1 SoC device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240617-haiku-coasting-2f1cdca0ed30@wendy>
Date: Mon, 17 Jun 2024 08:31:03 +0100
From: Conor Dooley <conor.dooley@...rochip.com>
To: Yixun Lan <dlan@...too.org>
CC: Yangyu Chen <cyy@...self.name>, <linux-riscv@...ts.infradead.org>, Conor
 Dooley <conor+dt@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, Paul
 Walmsley <paul.walmsley@...ive.com>, Samuel Holland
	<samuel.holland@...ive.com>, Anup Patel <anup.patel@....com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 7/9] riscv: dts: add initial SpacemiT K1 SoC device
 tree

On Sun, Jun 16, 2024 at 10:53:14PM +0000, Yixun Lan wrote:
> On 01:20 Mon 17 Jun     , Yangyu Chen wrote:
> > Banana Pi BPI-F3 motherboard is powered by SpacemiT K1[1].
> > 
> .. snip
> > +		uart0: serial@...17000 {
> > +			compatible = "intel,xscale-uart";
> are you sure the uart IP is fully compatible with xscale?
> otherwise I'd suggest to introduce a vendor specific one..

Definitely add a soc-specific compatible here, even if fully compatible
with the xscale uart. There's a marvell device doing this already.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)