linux-kernel - Re: [PATCH v2] pinctrl: fix deadlock in create_pinctrl() when handling -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbWeMtQ5upOQR--6RYzwcD+N_2o3OA11zT-sPr_SnQWwQ@mail.gmail.com>
Date: Mon, 17 Jun 2024 09:55:37 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Hagar Hemdan <hagarhem@...zon.com>
Cc: Maximilian Heyne <mheyne@...zon.de>, Norbert Manthey <nmanthey@...zon.de>, 
	Patrice Chotard <patrice.chotard@...com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: fix deadlock in create_pinctrl() when
 handling -EPROBE_DEFER

On Tue, Jun 4, 2024 at 10:58 AM Hagar Hemdan <hagarhem@...zon.com> wrote:

> In create_pinctrl(), pinctrl_maps_mutex is acquired before calling
> add_setting(). If add_setting() returns -EPROBE_DEFER, create_pinctrl()
> calls pinctrl_free(). However, pinctrl_free() attempts to acquire
> pinctrl_maps_mutex, which is already held by create_pinctrl(), leading to
> a potential deadlock.
>
> This patch resolves the issue by releasing pinctrl_maps_mutex before
> calling pinctrl_free(), preventing the deadlock.
>
> This bug was discovered and resolved using Coverity Static Analysis
> Security Testing (SAST) by Synopsys, Inc.
>
> Fixes: 42fed7ba44e4 ("pinctrl: move subsystem mutex to pinctrl_dev struct")
> Suggested-by: Maximilian Heyne <mheyne@...zon.de>
> Signed-off-by: Hagar Hemdan <hagarhem@...zon.com>

Looks like a real issue so patch applied for fixes.

Yours,
Linus Walleij