[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cd615a09-e9de-418b-9847-0d049671c2b4@linaro.org>
Date: Mon, 17 Jun 2024 10:21:40 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Gaurav Kashyap <quic_gaurkash@...cinc.com>,
linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
andersson@...nel.org, ebiggers@...gle.com, neil.armstrong@...aro.org,
srinivas.kandagatla@...aro.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, robh+dt@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
kernel@...cinc.com, linux-crypto@...r.kernel.org,
devicetree@...r.kernel.org, quic_omprsing@...cinc.com,
quic_nguyenb@...cinc.com, bartosz.golaszewski@...aro.org,
konrad.dybcio@...aro.org, ulf.hansson@...aro.org, jejb@...ux.ibm.com,
martin.petersen@...cle.com, mani@...nel.org, davem@...emloft.net,
herbert@...dor.apana.org.au, psodagud@...cinc.com, quic_apurupa@...cinc.com,
sonalg@...cinc.com
Subject: Re: [PATCH v5 14/15] arm64: dts: qcom: sm8650: add hwkm support to
ufs ice
On 17/06/2024 02:51, Gaurav Kashyap wrote:
> The Inline Crypto Engine (ICE) for UFS/EMMC supports the
> Hardware Key Manager (HWKM) to securely manage storage
> keys. Enable using this hardware on sm8650.
>
> This requires two changes:
> 1. Register size increase: HWKM is an additional piece of hardware
> sitting alongside ICE, and extends the old ICE's register space.
> 2. Explicitly tell the ICE driver to use HWKM with ICE so that
> wrapped keys are used in sm8650.
>
> Reviewed-by: Om Prakash Singh <quic_omprsing@...cinc.com>
> Tested-by: Neil Armstrong <neil.armstrong@...aro.org>
> Signed-off-by: Gaurav Kashyap <quic_gaurkash@...cinc.com>
> ---
> arch/arm64/boot/dts/qcom/sm8650.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index bb0b3c48ee4b..a34c4b7ccbac 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -2593,9 +2593,11 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> ice: crypto@...8000 {
> compatible = "qcom,sm8650-inline-crypto-engine",
> "qcom,inline-crypto-engine";
> - reg = <0 0x01d88000 0 0x8000>;
> + reg = <0 0x01d88000 0 0x10000>;
>
> clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
> +
> + qcom,ice-use-hwkm;
Nah... this proves this is compatible specific, so drop the property.
You already ignored such feedback once, so let me be clear: respond that
you acknowledge the comment and that you will implement it.
Best regards,
Krzysztof
Powered by blists - more mailing lists