linux-kernel - Re: [PATCH v2 2/5] arm64: dts: rockchip: Add bluetooth rfkill to Khadas Edge2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 13:19:17 +0400
From: Alexey Charkov <alexey.charkov@...ovo.ru>
To: Jacobe Zang <jacobe.zang@...ion.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de
Cc: nick@...das.com, efectn@...tonmail.com, jagan@...eble.ai,
 dsimic@...jaro.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] arm64: dts: rockchip: Add bluetooth rfkill to
 Khadas Edge2


On 17/06/2024 10:11, Jacobe Zang wrote:
> Add bluetooth node which managed by rfkill, bluetooth and
> wlan controller on Khadas Edge2 was BCM43438. In uart9 add
> RTS node in pinctrl.

You refer to wlan in the commit message, but there is nothing wlan 
related in the patch itself. Update the commit message perhaps?

> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>
> ---
>   .../boot/dts/rockchip/rk3588s-khadas-edge2.dts  | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> index 8c0bc675690dd..a82f10312eacd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> @@ -77,6 +77,14 @@ blue_led: led-2 {
>   		};
>   	};
>   
> +	bluetooth-rfkill {
> +		compatible = "rfkill-gpio";
> +		label = "rfkill-bluetooth";
> +		radio-type = "bluetooth";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&bt_reset_pin>;

Does it actually work this way? I thought you'd need to also reference 
the respective GPIO to be able to trigger its state, not just switch the 
pinctrl configuration to GPIO.


I'm also wondering if bt_reset_pin is the right one to use here. On my 
Rock 5B I had to trigger bt_wake_pin to get Bluetooth up and running.


Best regards,

Alexey