linux-kernel - Re: [PATCH v2 2/5] arm64: dts: rockchip: Add bluetooth rfkill to Khadas Edge2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 09:55:00 +0000
From: Jacobe Zang <jacobe.zang@...ion.com>
To: Alexey Charkov <alexey.charkov@...ovo.ru>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "heiko@...ech.de"
	<heiko@...ech.de>
CC: Nick Xie <nick@...das.com>, "efectn@...tonmail.com"
	<efectn@...tonmail.com>, "jagan@...eble.ai" <jagan@...eble.ai>,
	"dsimic@...jaro.org" <dsimic@...jaro.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-rockchip@...ts.infradead.org"
	<linux-rockchip@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/5] arm64: dts: rockchip: Add bluetooth rfkill to
 Khadas Edge2

> You refer to wlan in the commit message, but there is nothing wlan
> related in the patch itself. Update the commit message perhaps?

At that time, I want to describe that wlan and bluetooth were from the module named BCM43438. But, it's true that wlan do not be metioned in the code. I will update it in next version.

> I thought you'd need to also reference the respective GPIO to be able to trigger its 
> state, not just switch the pinctrl configuration to GPIO.

You means the shutdown-gpios? I configure it in the bluetooth node, it can't be configure in rfkill node at the same time.

> I'm also wondering if bt_reset_pin is the right one to use here. On my
> Rock 5B I had to trigger bt_wake_pin to get Bluetooth up and running.

Yes, I try to configure bt_reset_pin, bt_wake_host_irq and  bt_wake_pin in pinctrl separately. Each of them works well. After I connected a BT device to Edge2, I input rfkill block 1, bluetooth function failed. Then I input rfkill unblock 1, it can rework. So at last I only configure the bt_reset_pin.

---
Best Regards
Jacobe