linux-kernel - Re: [PATCH v2] arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnAAxlH6yhlJf6fV@hovoldconsulting.com>
Date: Mon, 17 Jun 2024 11:24:22 +0200
From: Johan Hovold <johan@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rajendra Nayak <quic_rjendra@...cinc.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100: Enable tsens and thermal
 zone nodes

On Fri, Jun 14, 2024 at 01:50:07PM +0300, Abel Vesa wrote:
> From: Rajendra Nayak <quic_rjendra@...cinc.com>
> 
> Add tsens and thermal zones nodes for x1e80100 SoC.
> 
> Signed-off-by: Rajendra Nayak <quic_rjendra@...cinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> ---
> Changes in v2:
> - Dropped the thermal engine nodes.
> - Dropped comments from tsens nodes.
> - Droppd the polling-delay entirely and polling-delay-passive where not
>   necessary.
> - Added top/bottom location to all sensors (where applicable).
> - Fixed trip points with duplicate values for same temp.
> - Marked as critical the 125°C throughout all trip points.
> - Link to v1: https://lore.kernel.org/r/20240527-x1e80100-dts-thermal-v1-1-ea13b8fa6ffc@linaro.org
> ---
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1176 ++++++++++++++++++++++++++++++++
>  1 file changed, 1176 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 9944c654851e..df13df7967db 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi

> +		cpu0-0-bottom-thermal {
> +			thermal-sensors = <&tsens0 2>;
> +
> +			trips {
> +				trip-point0 {
> +					temperature = <90000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
> +
> +				trip-point1 {
> +					temperature = <95000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
> +
> +				cpu-critical {
> +					temperature = <110000>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};
> +		};

The CPU bottom thermal zones fail to register with v2:

[    0.146219] thermal_sys: Thermal zone name (cpu0-0-bottom-thermal) too long, should be under 20 chars
[    0.146241] thermal_sys: Failed to register thermal zone cpu0-0-bottom-thermal: -22
[    0.146474] thermal_sys: Thermal zone name (cpu0-1-bottom-thermal) too long, should be under 20 chars
[    0.146495] thermal_sys: Failed to register thermal zone cpu0-1-bottom-thermal: -22
[    0.146753] thermal_sys: Thermal zone name (cpu0-2-bottom-thermal) too long, should be under 20 chars
[    0.146774] thermal_sys: Failed to register thermal zone cpu0-2-bottom-thermal: -22
[    0.147024] thermal_sys: Thermal zone name (cpu0-3-bottom-thermal) too long, should be under 20 chars
[    0.147045] thermal_sys: Failed to register thermal zone cpu0-3-bottom-thermal: -22
[    0.147297] thermal_sys: Thermal zone name (cpuss0-bottom-thermal) too long, should be under 20 chars
[    0.147319] thermal_sys: Failed to register thermal zone cpuss0-bottom-thermal: -22
[    0.149401] thermal_sys: Thermal zone name (cpu1-0-bottom-thermal) too long, should be under 20 chars
[    0.149423] thermal_sys: Failed to register thermal zone cpu1-0-bottom-thermal: -22
[    0.149765] thermal_sys: Thermal zone name (cpu1-1-bottom-thermal) too long, should be under 20 chars
[    0.149787] thermal_sys: Failed to register thermal zone cpu1-1-bottom-thermal: -22
[    0.150098] thermal_sys: Thermal zone name (cpu1-2-bottom-thermal) too long, should be under 20 chars
[    0.150119] thermal_sys: Failed to register thermal zone cpu1-2-bottom-thermal: -22
[    0.150437] thermal_sys: Thermal zone name (cpu1-3-bottom-thermal) too long, should be under 20 chars
[    0.150458] thermal_sys: Failed to register thermal zone cpu1-3-bottom-thermal: -22
[    0.150775] thermal_sys: Thermal zone name (cpuss1-bottom-thermal) too long, should be under 20 chars
[    0.150796] thermal_sys: Failed to register thermal zone cpuss1-bottom-thermal: -22
[    0.152838] thermal_sys: Thermal zone name (cpu2-0-bottom-thermal) too long, should be under 20 chars
[    0.152859] thermal_sys: Failed to register thermal zone cpu2-0-bottom-thermal: -22
[    0.153211] thermal_sys: Thermal zone name (cpu2-1-bottom-thermal) too long, should be under 20 chars
[    0.153232] thermal_sys: Failed to register thermal zone cpu2-1-bottom-thermal: -22
[    0.153603] thermal_sys: Thermal zone name (cpu2-2-bottom-thermal) too long, should be under 20 chars
[    0.153624] thermal_sys: Failed to register thermal zone cpu2-2-bottom-thermal: -22
[    0.153994] thermal_sys: Thermal zone name (cpu2-3-bottom-thermal) too long, should be under 20 chars
[    0.154015] thermal_sys: Failed to register thermal zone cpu2-3-bottom-thermal: -22
[    0.154386] thermal_sys: Thermal zone name (cpuss2-bottom-thermal) too long, should be under 20 chars
[    0.154407] thermal_sys: Failed to register thermal zone cpuss2-bottom-thermal: -22

Johan