linux-kernel - Re: [v4 2/3] leds: sy7802: Add support for Silergy SY7802 flash LED controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 13:59:37 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Pavel Machek <pavel@....cz>, 
	André Apitzsch <git@...tzsch.eu>, linux-leds@...r.kernel.org, phone-devel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	~postmarketos/upstreaming@...ts.sr.ht, Bjorn Andersson <andersson@...nel.org>, 
	Christophe Jaillet <christophe.jaillet@...adoo.fr>, Conor Dooley <conor+dt@...nel.org>, 
	"Gustavo A. R. Silva" <gustavoars@...nel.org>, Kees Cook <kees@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Lee Jones <lee@...nel.org>, Trilok Soni <quic_tsoni@...cinc.com>, 
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [v4 2/3] leds: sy7802: Add support for Silergy SY7802 flash LED
 controller

On Mon, Jun 17, 2024 at 12:18:11PM GMT, Markus Elfring wrote:
> >> Would you become interested to apply a statement like “guard(mutex)(&chip->mutex);”?
> >> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196
> >
> > This does not look like real improvement for code this trivial.
> 
> Various source code places can be updated also according to referenced
> programming interfaces.
> https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L8
> 
> Will corresponding collateral evolution become better supported?

Plesae stop this. cleanup.h might be a nice thing, but it should not be
used to make code less obvious or worse.

-- 
With best wishes
Dmitry