linux-kernel - Re: [PATCH v2 4/5] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 15:17:50 +0400
From: Alexey Charkov <alchark@...il.com>
To: Jacobe Zang <jacobe.zang@...ion.com>
Cc: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>, 
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "heiko@...ech.de" <heiko@...ech.de>, Nick Xie <nick@...das.com>, 
	"efectn@...tonmail.com" <efectn@...tonmail.com>, "jagan@...eble.ai" <jagan@...eble.ai>, 
	"dsimic@...jaro.org" <dsimic@...jaro.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, 
	"linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] arm64: dts: rockchip: Add AP6275P wireless support
 to Khadas Edge 2

On Mon, Jun 17, 2024 at 2:58 PM Jacobe Zang <jacobe.zang@...ion.com> wrote:
>
> >I'm also wondering why would adding a DT node for a PCI device be needed
> >in the first place, given that PCI supports device discovery?
>
> In fact, I learn that PCIe bus devices do not need compatible to probe just now... Before sending this patch, I committed the code that added "pci14e4,449d" to vendor-prefix.yaml and net/wireless/brcm,brcm4329-fmac.yaml. Now I know the reason why my addition was rejected. By the way, except for the compatible binding, is there any other binding that I should remove??

If your PCI bridge is functioning properly and if your WiFi adapter is
connected and physically enabled (in terms of power and RFKILL) I
believe it should be automatically discovered and you should see it in
lspci. No additional DT nodes needed - but check if you need any
additional DT property somewhere to keep the HYM8563 clock enabled.
I'm not sure your pcie@0,0 node is needed either.

Then it's up to the driver to recognize your adapter by its PCI ID and
attach. I guess you'd need to extend the hardware IDs table in the
brcmfmac driver for it to attach - similar to [1]

[1] https://github.com/armbian/build/blob/main/patch/kernel/archive/rockchip-rk3588-6.10/0801-wireless-add-bcm43752.patch

Best regards,
Alexey